Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ltimes kernel underbenchmarks it out of date #1737

Closed
artv3 opened this issue Sep 18, 2024 · 4 comments
Closed

ltimes kernel underbenchmarks it out of date #1737

artv3 opened this issue Sep 18, 2024 · 4 comments

Comments

@artv3
Copy link
Member

artv3 commented Sep 18, 2024

Describe the bug

ltimes kernel under benchmarks it out of date. Some of the features it uses may not be supported or have moved namespace.

To Reproduce

Build ltimes which is found in the benchmark.

Expected behavior

It should build.

@rhornung67
Copy link
Member

Since there are two versions of LTIMES in RAJAPerf that are implemented using all RAJA variants, we could delete it in RAJA benchmarks.

@artv3
Copy link
Member Author

artv3 commented Sep 19, 2024

The neat feature of the version in the benchmark folder is that it has a number of variations, launch, kernel, shared memory and usage of the vectorization framework. I was going take a few mins today to see if I can bring it up to date. If there are things missing I can reach out so we can further discuss.

@artv3
Copy link
Member Author

artv3 commented Sep 19, 2024

I was able to address some of the issues in this PR: #1738.

However; other areas involve the vectorization capabilities. I discussed with @rchen20 and he offered to take a look.

@rhornung67
Copy link
Member

@artv3 can this issue be closed?

@artv3 artv3 closed this as completed Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants