Fix a potential crash upon pausing in iOS and macOS

LIJI32 · May 31, 2024 · b1fec62 · b1fec62
1 parent 2bf8feb
commit b1fec62
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/Cocoa/Document.m b/Cocoa/Document.m
@@ -564,8 +564,7 @@ - (void)postRun
 {
     [_hexTimer invalidate];
     [_audioLock lock];
-    memset(_audioBuffer, 0, (_audioBufferSize - _audioBufferPosition) * sizeof(*_audioBuffer));
-    _audioBufferPosition = _audioBufferNeeded;
+    _audioBufferPosition = _audioBufferNeeded = 0;
     [_audioLock signal];
     [_audioLock unlock];
     [_audioClient stop];

diff --git a/iOS/GBViewController.m b/iOS/GBViewController.m
@@ -891,10 +891,7 @@ - (UIImage *)imageFromData:(NSData *)data width:(unsigned)width height:(unsigned
 - (void)postRun
 {
     [_audioLock lock];
-    if (_audioBuffer) {
-        memset(_audioBuffer, 0, (_audioBufferSize - _audioBufferPosition) * sizeof(*_audioBuffer));
-    }
-    _audioBufferPosition = _audioBufferNeeded;
+    _audioBufferPosition = _audioBufferNeeded = 0;
     [_audioLock signal];
     [_audioLock unlock];
     [_audioClient stop];