Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would be great with some integration tests #22

Closed
Nicoolai opened this issue Sep 7, 2022 · 2 comments
Closed

Would be great with some integration tests #22

Nicoolai opened this issue Sep 7, 2022 · 2 comments
Assignees

Comments

@Nicoolai
Copy link
Contributor

Nicoolai commented Sep 7, 2022

Is your feature request related to a problem? Please describe

Even if the plugin builds, I have no idea if it actually works when loaded into Kong.

Describe the solution you'd like

Automated integration testing in the build pipeline.

Describe alternatives you've considered

N/A

Additional context

N/A

@hafstroem hafstroem self-assigned this Sep 16, 2024
@hafstroem
Copy link
Contributor

Hey @Nicoolai
I added some integration tests here: #43
They will test the validity of the signature created and also the effect of a few of the configuration options.
Can we close this issue?

@Nicoolai
Copy link
Contributor Author

Hey @Nicoolai I added some integration tests here: #43 They will test the validity of the signature created and also the effect of a few of the configuration options. Can we close this issue?

Absolutely :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants