Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SuperPacket in pfdecoder #77

Open
tomeichlersmith opened this issue May 11, 2022 · 1 comment
Open

Use SuperPacket in pfdecoder #77

tomeichlersmith opened this issue May 11, 2022 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@tomeichlersmith
Copy link
Member

pfdecoder was started before SuperPacket was implemented, now that SuperPacket is here, we should use it within pfdecoder so that future changes to the decoding only need to be done in one place.

@tomeichlersmith tomeichlersmith added the bug Something isn't working label May 11, 2022
@tomeichlersmith tomeichlersmith added this to the v3.0 milestone May 11, 2022
@tomeichlersmith
Copy link
Member Author

I think a more long-lasting idea would be to update the decoding sub module to be a more modern C++ implementation of a decoding class. This would mean the member variables would be the already decoded values of interest. The inputs to a constructor would be a std::vector<uint32_t> and there would be a input-stream class for reading out the data from a file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant