Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default trigger thresholds #1469

Merged
merged 5 commits into from
Sep 27, 2024

Conversation

EBerzin
Copy link
Contributor

@EBerzin EBerzin commented Sep 20, 2024

I am updating ldmx-sw, here are the details.

What are the issues that this addresses?

This resolves #1468. I've updated the 8 GeV default thresholds to reflect the optimized values calculated for a mu=1 Poisson beam profile, and 20 ECal layers. The 1e threshold was kept at 3 GeV, which also happens to be consistent with the optimized value (3.01 GeV).

Thresholds for 4 GeV were also updated to reflect thresholds calculated by Megan, as reported here: https://indico.fnal.gov/event/51366/contributions/225984/attachments/148282/190432/MeganLoh_multielectronTriggering.pdf

The 1e- threshold at 4 GeV was kept at 1.5 GeV.

Check List

  • I successfully compiled ldmx-sw with my developments
  • I ran my developments and the following shows that they are successful.

@EBerzin EBerzin linked an issue Sep 20, 2024 that may be closed by this pull request
@EBerzin EBerzin requested review from tvami and bryngemark September 20, 2024 05:38
Copy link
Member

@tvami tvami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I have one small comment:

Recon/python/simpleTrigger.py Outdated Show resolved Hide resolved
Recon/python/simpleTrigger.py Outdated Show resolved Hide resolved
Recon/python/simpleTrigger.py Outdated Show resolved Hide resolved
@tvami tvami requested a review from bryngemark September 20, 2024 19:32
@tvami
Copy link
Member

tvami commented Sep 26, 2024

Thanks @EBerzin !

@tvami
Copy link
Member

tvami commented Sep 26, 2024

Thanks @EBerzin !

Actually one more thing: can you please edit the PR description too to reflect you also changed the 4 GeV settings (with a link to the talk from Megan)

@tvami
Copy link
Member

tvami commented Sep 26, 2024

I'd like to trigger the full test, for that I'll move this to "draft" and back to "ready"

@tvami tvami marked this pull request as draft September 26, 2024 19:06
@tvami tvami marked this pull request as ready for review September 26, 2024 19:07
@tvami
Copy link
Member

tvami commented Sep 26, 2024

Screenshot 2024-09-26 at 14 23 56

OK the only plot failing is this. I think it's expected since that's the only PU workflow we have, and the change on the plot is exactly what we change. It's actually even a bit surprising that it didnt have more visible effects downstream.

@tomeichlersmith tomeichlersmith merged commit 6199947 into trunk Sep 27, 2024
10 of 11 checks passed
@tomeichlersmith tomeichlersmith deleted the 1468-change-trigger-threshold-defaults branch September 27, 2024 18:57
@bryngemark
Copy link
Contributor

bryngemark commented Sep 28, 2024

there are a few places where the trigger decision differs but I guess either a) there are no trigger pass/fail plots in the DQM b) the KS test still judges the distributions to be "from the same underlying distribution"

examples from the log diff:

  < [ trigger ] 68 debug: Got trigger energy cut 10000 for 2 electrons counted in the event.
  < [ trigger ] 68 debug: Got trigger energy sum 10147.9; and decision is pass = false
  ---
  > [ trigger ] 68 debug: Got trigger energy cut 10790 for 2 electrons counted in the event.
  > [ trigger ] 68 debug: Got trigger energy sum 10147.9; and decision is pass = true
[...]
  < [ trigger ] 334 debug: Got trigger energy cut 10000 for 2 electrons counted in the event.
  < [ trigger ] 334 debug: Got trigger energy sum 10210.8; and decision is pass = false
  ---
  > [ trigger ] 334 debug: Got trigger energy cut 10790 for 2 electrons counted in the event.
  > [ trigger ] 334 debug: Got trigger energy sum 10210.8; and decision is pass = true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change trigger threshold defaults
4 participants