Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PU CI validation scripts #1487

Open
tvami opened this issue Oct 14, 2024 · 0 comments · May be fixed by #1518
Open

Update PU CI validation scripts #1487

tvami opened this issue Oct 14, 2024 · 0 comments · May be fixed by #1518
Labels
config validation

Comments

@tvami
Copy link
Member

tvami commented Oct 14, 2024

Is your feature request related to a problem? Please describe.

This
https://github.com/LDMX-Software/ldmx-sw/blob/trunk/.github/validation_samples/it_pileup/gen_main.py#L12
and
https://github.com/LDMX-Software/ldmx-sw/blob/trunk/.github/validation_samples/it_pileup/gen_pileup.py#L11
are still at 4 GeV.

This line
https://github.com/LDMX-Software/ldmx-sw/blob/trunk/.github/validation_samples/it_pileup/config.py#L100
would be better with dqm.ecal_dqm

Generally now that we've been running 2e samples this should be updated.

Describe the solution you'd like

Update the configs
@tvami tvami linked a pull request Jan 18, 2025 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
config validation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ACTS tracking in all CIs LDMX-Software/ldmx-sw
1 participant
@tvami