Persist the actual simulated position of the ECAL hit rather than the cell center #1485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK I think it's worth doing this. |
tvami
force-pushed
the
iss1484-keep-real-simhit-pos
branch
from
e8ee960 to
ea2202d
Compare
|
I added the new plots: Y Z X/Y makes a lot of sense. Z is what I believe is what's in #1490 |
|
@tomeichlersmith what do you think about the Z? Should I have #1490 takled in this PR too? Or maybe just open another PR... but then I dont know what to do with the weights |
I think it's prob better to be in another PR provided that we dont have too much time in between the two PRs. Then I can easily compare these plots to show the changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am updating ldmx-sw, here are the details.
What are the issues that this addresses?
Resolves #1484
Resolves #1482
But I'm only opening it as a draft first to see the effect using the CI tests
Check List