Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homogenize names of functions #809

Closed
wants to merge 8 commits into from
Closed

Homogenize names of functions #809

wants to merge 8 commits into from

Conversation

stelmo
Copy link
Collaborator

@stelmo stelmo commented Dec 17, 2023

Added suffix _analysis to all the one-shot functions, so that it is more obvious that they are the "easy" mode functions. Also people expect flux_balance_analysis not flux_balance.

Added prefix build_ to all functions that build new constraint trees. Again, I think this consistent naming pattern will help people when they do COBREXA.<tab> to figure out what to use and what not to use.

Moved modifications to misc.

@stelmo
Copy link
Collaborator Author

stelmo commented Dec 17, 2023

/format

@stelmo stelmo requested a review from exaexa December 17, 2023 11:14
Copy link
Contributor

✔️ Auto-formatting triggered by this comment succeeded, commited as c4a9a36

github-actions bot pushed a commit that referenced this pull request Dec 17, 2023
triggered by @stelmo on PR #809
@stelmo stelmo force-pushed the sew-homogenize-analysis branch from c4a9a36 to 80f502a Compare December 17, 2023 11:30
@stelmo
Copy link
Collaborator Author

stelmo commented Dec 17, 2023

/format

triggered by @stelmo on PR #809
Copy link
Contributor

✔️ Auto-formatting triggered by this comment succeeded, commited as 656561e

@exaexa exaexa added the quality improves maintainability and code clarity label Dec 18, 2023
@exaexa exaexa added this to the v2.0.x milestone Dec 18, 2023
Base automatically changed from sew-enzyme-models to next December 28, 2023 13:32
@stelmo
Copy link
Collaborator Author

stelmo commented Dec 28, 2023

will make a new PR, too much has changed since I made this one

@stelmo stelmo closed this Dec 28, 2023
@stelmo stelmo deleted the sew-homogenize-analysis branch January 4, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality improves maintainability and code clarity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants