Add max min driving force capability #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess all good, can we merge into the enzyme branch? That one is also good, I'll just need to go through that. |
exaexa
requested changes
Dec 16, 2023
|
Yep, let me just fix up the docs, then merge in there |
|
boom 🚀 💥 |
|
/format |
|
✔️ Auto-formatting triggered by this comment succeeded, commited as dcf93d4 |
|
So the only thing failing is my cowboy test in enzymes |
exaexa
force-pushed
the
sew-thermodynamic-models
branch
2 times, most recently
from
67506c0 to
db1e52b
Compare
exaexa
reviewed
Dec 16, 2023
exaexa
approved these changes
Dec 16, 2023
exaexa
force-pushed
the
sew-thermodynamic-models
branch
from
db1e52b to
841d02e
Compare
|
ok good all errors are in the other MR already |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested against v1, and they generate the same solution.