Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse common attributes from notes #684

Open
htpusa opened this issue Oct 17, 2022 · 3 comments
Open

Parse common attributes from notes #684

htpusa opened this issue Oct 17, 2022 · 3 comments
Labels
feature New feature/functionality
Milestone

Comments

@htpusa
Copy link
Collaborator

htpusa commented Oct 17, 2022

Some older models hide reaction attributes such as GPRs in notes, these are currently not parsed. Notable example:

https://systemsbiology.ucsd.edu/sites/systemsbiology.ucsd.edu/files/Attachments/Images/InSilicoOrganisms/Ecoli/Ecoli_SBML/Ec_core_flux1.xml

The most important one is probably the GPR since it has an accessor and thus users are expecting to find it.

@htpusa
Copy link
Collaborator Author

htpusa commented Oct 17, 2022

"SUBSYSTEM" is another potentially relevant one.

@exaexa exaexa added this to the v1.5 milestone Oct 17, 2022
@exaexa exaexa added the feature New feature/functionality label Oct 17, 2022
@exaexa
Copy link
Collaborator

exaexa commented Oct 17, 2022

We're not going to put this into the parsing process directly (storing stuff in notes just....you shouldn't) but we can make a tiny wrapper atop SBMLModel that re-parses the notes in the right way without breaking anything else. I'll ping you with a test implementation asap.

@exaexa
Copy link
Collaborator

exaexa commented May 14, 2024

@htpusa in one other project we found that there's a unitilty to convert these annotations to the "proper" FBC form; you can do it with reframed:

model=reframed.load_cbmodel('something.xml',flavor='cobra')
reframed.save_cbmodel(model,'something_fbc.xml',flavor='bigg')

(Thanks go to Arianna Basile for this)

Also we should move this issue to the SBMLFBCModels. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature/functionality
Projects
None yet
Development

No branches or pull requests

2 participants