Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0 staging PR #673

Closed
wants to merge 605 commits into from
Closed

v2.0 staging PR #673

wants to merge 605 commits into from

Conversation

exaexa
Copy link
Collaborator

@exaexa exaexa commented Sep 24, 2022

This is a container for all breaking PRs that will be merged into 2.0.

Rules:

  • keep this sufficienty rebased/backmerged and mergeable into develop

Notes about what not to forget before merging to develop:

  • check if the docs build (this PR should be ❌ otherwise)
  • remove the nextdevelop doc build trigger
  • quadruple check rebase status

Leftovers from other issues:

  • kill all "previously internal" identifiers that start with _
  • fix docs
  • write a doc page about the module structure

@exaexa exaexa added do not merge When a PR is labelled as such, do not merge ❌ breaking Merging requires a major version bump labels Sep 24, 2022
@exaexa exaexa added this to the v2.0 milestone Sep 24, 2022
@exaexa exaexa marked this pull request as draft September 24, 2022 12:57
@exaexa exaexa changed the base branch from master to develop September 24, 2022 12:58
@exaexa exaexa mentioned this pull request Oct 21, 2022
5 tasks
@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Base: 90.60% // Head: 90.21% // Decreases project coverage by -0.38% ⚠️

Coverage data is based on head (8c04d42) compared to base (40c15f8).
Patch coverage: 89.89% of modified lines in pull request are covered.

❗ Current head 8c04d42 differs from pull request most recent head 2282aa7. Consider uploading reports for the commit 2282aa7 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #673      +/-   ##
===========================================
- Coverage    90.60%   90.21%   -0.39%     
===========================================
  Files           82       82              
  Lines         2150     2106      -44     
===========================================
- Hits          1948     1900      -48     
- Misses         202      206       +4     
Impacted Files Coverage Δ
src/analysis/flux_balance_analysis.jl 100.00% <ø> (ø)
src/analysis/max_min_driving_force.jl 93.84% <ø> (ø)
src/analysis/modifications/loopless.jl 100.00% <ø> (ø)
...alysis/reconstruction/gapfill_minimum_reactions.jl 88.63% <ø> (ø)
src/io/show/FluxSummary.jl 0.00% <0.00%> (ø)
src/io/show/FluxVariabilitySummary.jl 0.00% <0.00%> (ø)
src/io/show/Serialized.jl 0.00% <0.00%> (ø)
src/macros/model_wrapper.jl 0.00% <ø> (ø)
src/reconstruction/modifications/enzymes.jl 100.00% <ø> (ø)
src/types/ReactionStatus.jl 100.00% <ø> (ø)
... and 67 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@exaexa
Copy link
Collaborator Author

exaexa commented Jan 29, 2024

Let's move this to COBREXA namespace ASAP to get the github-based testsuite working (apparently we need to push the rules to master before it gets sourced)

@exaexa
Copy link
Collaborator Author

exaexa commented Jan 30, 2024

COBREXA 2.0 continues at https://github.com/COBREXA/COBREXA.jl

@exaexa exaexa closed this Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge When a PR is labelled as such, do not merge ❌ breaking Merging requires a major version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants