Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change reaction constraints using un-mangled reaction id #633

Closed
stelmo opened this issue Jun 9, 2022 · 3 comments
Closed

Change reaction constraints using un-mangled reaction id #633

stelmo opened this issue Jun 9, 2022 · 3 comments
Assignees
Labels
feature New feature/functionality
Milestone

Comments

@stelmo
Copy link
Collaborator

stelmo commented Jun 9, 2022

right now the change constraint modification uses reactions(model) to set bounds on variables. For more complicated models like GeckoModels you can't use the natural (un-mangled) reaction ids to set the bounds on variables. We should fix it so that the users can do this without having to look-up the mangled ones (or changing the underlying model).

@stelmo stelmo added the feature New feature/functionality label Jun 9, 2022
@stelmo stelmo self-assigned this Jun 9, 2022
@exaexa
Copy link
Collaborator

exaexa commented Jul 20, 2022

this could basically multiply the constraint through the reaction_fluxes matrix and add it as is. Certainly doable, I'll have a look at it.

OTOH if possible one should preferably set the "base" reaction bounds on the original model before it gets through gecko construction.

@exaexa exaexa added this to the Wishlist milestone Sep 2, 2022
@exaexa
Copy link
Collaborator

exaexa commented Sep 2, 2022

naming: change_constraint vs change_flux_bound ?

(future after rename: change_variable_constraint vs change_reaction_constraint ?)

@exaexa
Copy link
Collaborator

exaexa commented May 14, 2024

solved differently (no mangling in C2)

@exaexa exaexa closed this as completed May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature/functionality
Projects
None yet
Development

No branches or pull requests

2 participants