several improvements of workflow #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add devcontainer CI build workflow * contain an `src/` directory, which is where all packages should go, as then the root of the repository can itself serve as a colcon workspace (works best for dev containers) * configures `.dockerignore` and `.gitignore` to ensure that any colcon-generated files (as repository root is also workspace) don't end up in code base etc. * create a `post-create` command that is executed on container creation and auto-configures the `~/.bashrc` with the local workspace and attempts to build the whole colcon workspace. This is to speed up later builds as all packages that can be build already automatically are. * updated documentation to match this
|
@ibrahimhroob, I think this is an improvement to the template, based on my experience with devcontainers ans ros2 overall. Happy to discuss |
marc-hanheide
commented
Apr 25, 2024
| @@ -10,7 +10,7 @@ RUN apt-get update \ | |||
|
|
|||
| # get the source tree and analyse it for its package.xml only | |||
| FROM base as sourcefilter | |||
| COPY . /tmp/src | |||
| COPY ./src /tmp/src | |||
There was a problem hiding this comment.
now all packages should be under src/
| bin/ | ||
| lib/ | ||
| install/ | ||
| *~ |
There was a problem hiding this comment.
ignore all directories etc that are generated by colcon, also ignore changes to readme etc as they are just documentation
| imageName: lcas.lincoln.ac.uk/devcontainer/${{ steps.docker_image_name.outputs.docker_image }} | ||
| push: never | ||
| imageTag: ${{ env.BRANCH }} | ||
| #runCmd: "bash .devcontainer/run-ci.sh" |
There was a problem hiding this comment.
This is a new CI workflow, that ensures that the devcontainer image can be build. Basically it guarantees that the devcontainer image on the main branch always works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src/directory, which is where all packages should go, as then the root of the repository can itself serve as a colcon workspace (works best for dev containers).dockerignoreand.gitignoreto ensure that any colcon-generated files (as repository root is also workspace) don't end up in code base etc.post-createcommand that is executed on container creation and auto-configures the~/.bashrcwith the local workspace and attempts to build the whole colcon workspace. This is to speed up later builds as all packages that can be build already automatically are.