feature: Automatically reconnect the websocket connection on close #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't this need some sort of delay or debounce? Wouldn't it start spamming requests? |
kezz
commented
Jul 24, 2023
Comment on lines
-501
to
-502
| val warning = document.element<HTMLTextAreaElement>("connection-lost-warning") | ||
| val inputBox = document.element<HTMLTextAreaElement>("input") |
There was a problem hiding this comment.
Should remove the HTML for this too
There was a problem hiding this comment.
This still makes sense to have in cases where, for example the user has lost internet connection altogether, where there should be some evidence that the reconnection is being attempted
|
I agree with rymiel, a set timeout or even better, exceptional backoff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite simple, just recreate the websocket and reinitialize it whenever it closes. Unsure if this will have any janky side-effects, but seems to work okay.
Closes #165.