Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Add_usd_price_and_amount_to_tradelogs #53

Merged
merged 5 commits into from
Jul 9, 2024

Conversation

Haiss2
Copy link
Member

@Haiss2 Haiss2 commented Jul 5, 2024

  • Add usd price and amount for maker token and taker token
  • Add binance client and ks-settings client to get token catalog
  • Add price-filler package to fill usd price and amount for tradelog
  • Add backfill routine to price-filler to fill for old data

@Haiss2 Haiss2 force-pushed the Feature/Add_usd_price_and_amount_to_tradelogs branch 4 times, most recently from d1d7ba4 to c68527f Compare July 5, 2024 09:16
@Haiss2 Haiss2 force-pushed the Feature/Add_usd_price_and_amount_to_tradelogs branch from 6db1a89 to 7e11b36 Compare July 8, 2024 03:22
@Haiss2 Haiss2 requested a review from ngocthanh1389 July 8, 2024 03:46
pkg/pricefiller/price_fillter.go Outdated Show resolved Hide resolved
pkg/pricefiller/flags.go Show resolved Hide resolved
@Haiss2 Haiss2 requested a review from ngocthanh1389 July 9, 2024 03:15
Copy link
Member

@ngocthanh1389 ngocthanh1389 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Haiss2 Haiss2 merged commit 2ec9905 into main Jul 9, 2024
6 checks passed
@Haiss2 Haiss2 deleted the Feature/Add_usd_price_and_amount_to_tradelogs branch July 9, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants