You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the kyber swap elastic contract at the 'estimateIncrementalLiquidity' function, if the isToken0 = false then the 'b' variable will be equal to feeInFeeUnit is subtracted from C.FEE_UNITS, multiplied by liquidity, but in the sdk implementation multiplication is missing
Proof:
Part of original SwapMath.lib of Kyber swap elastic pool contract:
Implementation of the 'estimateIncrementalLiquidity' of the SDK:
Error:
In the kyber swap elastic contract at the 'estimateIncrementalLiquidity' function, if the isToken0 = false then the 'b' variable will be equal to feeInFeeUnit is subtracted from C.FEE_UNITS, multiplied by liquidity, but in the sdk implementation multiplication is missing
Proof:
Part of original SwapMath.lib of Kyber swap elastic pool contract:
Implementation of the 'estimateIncrementalLiquidity' of the SDK:
ks-sdk-elastic/src/utils/swapMath.ts
Line 185 in e277662
@viet-nv could you please check it?
The text was updated successfully, but these errors were encountered: