Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import firebaseConfig in App.js #4

Closed

Conversation

kriscarilloxyz
Copy link

@kriscarilloxyz kriscarilloxyz commented Oct 3, 2020

Added an empty firebase config in FireConfig.js and comment to let developers know what to do first before working on the project. Fixed #1

@juliolopezn
Copy link

I can recommend you use enviroment variables.
https://create-react-app.dev/docs/adding-custom-environment-variables/

@juliolopezn
Copy link

juliolopezn commented Oct 3, 2020

This doesn't fix #1 issue

@kriscarilloxyz
Copy link
Author

There is no need to create environment variables with firebase configs, no need to hide it either as long as you impose security rules. Source https://stackoverflow.com/questions/37482366/is-it-safe-to-expose-firebase-apikey-to-the-public

#1 issue was there's a missing file for the firebase config.

Instead of throwing an error that there's no FireConfig.js a better alternative is to throw a firebase config error that no firebase app has been initialized, which will help first timers know what to do first.

The other issues in #1 should be created as separate issues in the repo. Goodluck.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sendMessage() not working
2 participants