Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block dns provider secret deletion when it's still referenced by a DNSRecord #344

Open
mikenairn opened this issue Jan 16, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@mikenairn
Copy link
Member

This has been discussed before, and the current approach is to put it on the user to make sure all DNSRecords referencing a dns provider secret are deleted first. This isn't a great experience, especially during testing.

This ticket is to look into alternative options, if there are any, to allow the secret to remain in place while still being referenced by any existing DNSRecord.

Related:

@mikenairn mikenairn added the enhancement New feature or request label Jan 16, 2025
@maleck13
Copy link
Collaborator

The main issue I see is if the secret is referenced by more than one policy / record. Do we need a refernce count. IE how many records reference this secret and then if the ref count hits 0 remove the finalizer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

2 participants