Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit more compiler warnings #13

Open
KristianLyng opened this issue Nov 13, 2014 · 1 comment
Open

Emit more compiler warnings #13

KristianLyng opened this issue Nov 13, 2014 · 1 comment

Comments

@KristianLyng
Copy link
Owner

There are a whole buck-load more compiler warnings we could emit. I am adding this as a TODO-item because I want to fix the warnings we have before I add more warnings. See #12 for that.

@KristianLyng KristianLyng modified the milestone: 0.8.8 + 1 Nov 14, 2014
@KristianLyng
Copy link
Owner Author

I did a dry-run of this today with my now-usual set of warnings, and unsurprisingly there were two major sinners:

const-correctness (we actually got a patch for this in beryl, but because it was mindboggingly huge and from an unkown, we didn't accept it). This is largely about option-stuff that's easily fix.

unused parameters - this is what we get for tons of generic interfaces. Some of it should probably be fixed.

In addition to that there were a set of shadowed variables I resolved. These are mostly a result of really bad code practices (huge functions, global variables, copy/paste).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant