Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Video controls under safe zone on new iPhones #248

Open
Ludotrico opened this issue Jan 19, 2021 · 3 comments
Open

[BUG] Video controls under safe zone on new iPhones #248

Ludotrico opened this issue Jan 19, 2021 · 3 comments

Comments

@Ludotrico
Copy link

Ludotrico commented Jan 19, 2021

Devices that do not have home buttons instead have a greater safe zone at the bottom of the screen. When playing a video, this safe zone is ignored and the video controls are too low to interact with.

Here is a picture of the issue.

@ionut-lucaci
Copy link

I am also experiencing this

@Ludotrico
Copy link
Author

Please let me know if you have seen this @kellyroach @jfahrenkrug @woko666 @RuiAAPeres

@hanawat
Copy link

hanawat commented Feb 12, 2022

I've found a temporary workaround.
footerView avoids safe area, so you just need to add a dummy view.

The default layout has a 25pt margin at the bottom.
https://github.com/Krisiacik/ImageViewer/blob/6.0.0/ImageViewer/Source/GalleryViewController.swift#L45
If you don't need it, set the footerViewLayout to 0.

let viewController = GalleryViewController(
  startIndex: index,
  itemsDataSource: datSource,
  configuration: [.footerViewLayout(.center(.zero))]
)
viewController.footerView = .init()
presentImageGallery(viewController)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants