-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement: Use of BatchGetSecretValue to lower API calls #95
Comments
If you want to put some time for an explorative PR, I want to see how it would look like. |
Will do. So far main pain point I'm seeing is that it would be a 'breaking' change,
|
May I suggest adding a property to the configuration provider and use that property to influence the backend provider source? This would allow us to keep the current behavior without breaking existing users. |
Exactly what i came looking for since POCing Secrets Manager and discovering this library (which i totally assumed their .NET SDK would already have..). |
@to11mtm I did a quick run and aside from one small possible bug (i left a comment), It seems to work well. Tried with all my secrets (~150) and it chunked them and called the list and batchfetch APIs the appropriate amount of times, all secrets were available with the correct values, etc. |
Basically, observation is that we use
GetSecretValue
inSecretManagerConfigurationProvider
Thought being, we could instead use
BatchGetSecretValue
API to retrieve up to 20 secrets at a time.Biggest benefit would be to library consumers who have refresh set up and have many secrets, as it should lower the overall number of API calls and thus cost (also, hopefully would help with startup and refresh times.)
Note: Some consideration might be needed around how the API works alongside the request in #94, but I don't think it's big lift.
I'm happy to do this as a PR if it is ok with Author.
The text was updated successfully, but these errors were encountered: