Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues against Localstack #20

Open
HK8080 opened this issue Oct 3, 2019 · 2 comments
Open

Issues against Localstack #20

HK8080 opened this issue Oct 3, 2019 · 2 comments

Comments

@HK8080
Copy link

HK8080 commented Oct 3, 2019

Hi,

I am quite new to AWS stuff and I am using your lib - btw, thanks for it - based on examples provided. I am using it from ASP.NET Core 2.2 app against AWS Localstack running in Docker. I found a few issues:

  1. I had to set:

opts.ConfigureSecretsManagerConfig = c => { c.AuthenticationRegion = <my_non_default_region_system_name> };

for it to work (in addition to region parameter for AddSecretsManager extension method). Otherwise, it was not failing, but no response (empty list) of secrets had been silently returned (200 response code from Secrets Manager in LS) in FetchAllSecretsAsync method.

  1. Deleted secrets are not filtered by default. (I filtered them out in my SecretFilter implementation). Might be nice option (true/filtered out by default) to filter them automatically (SecretsManagerConfigurationProvider.LoadAsync/FetchAllSecretsAsync method).

  2. For some reason, ARNs (their UUID suffix) seem to be changed by LS Secrets Manager with every request... Therefore, GetSecretValueAsync (inside SecretsManagerConfigurationProvider.LoadAsync loop) failed not being able to find requested resource/secret value (based on ARN passed from FetchAllSecretsAsync result). Changing the search criterion to secretValueRequest.SecretId = secret.Name; helped me (I am using prefixed keys like suggested here).

In case some of my findings are relevant, you can consider them for reflecting in the next version of the package.

Thanks.

@Kralizek
Copy link
Owner

Kralizek commented Oct 3, 2019

Hi @HK8080,
Thanks for posting your issue and I'm glad you find this library helpful!

Unfortunately, I never used Localstack so I don't have any direct experience.
Maybe @Erwinvandervalk, who added the support for alternative endpoints in #15, can provide you some help!

@remcobosman
Copy link

I am having the same problem working against LocalStack, specifically number 3 is blocking me as I cannot get past that. I am happy to put in a pull request (but I think I do not have permissions to do so).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants