Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The same serial descriptor name is used for several serializers #416

Open
dkhalanskyjb opened this issue Jul 24, 2024 · 0 comments · May be fixed by #415
Open

The same serial descriptor name is used for several serializers #416

dkhalanskyjb opened this issue Jul 24, 2024 · 0 comments · May be fixed by #415
Labels
breaking change This could break existing code bug Something isn't working
Milestone
0.7.0

Comments

@dkhalanskyjb
Copy link
Collaborator

SerialDescriptor must have a unique name, but we use one name per library entity, even when there are multiple serializers.
@dkhalanskyjb dkhalanskyjb added bug Something isn't working breaking change This could break existing code labels Jul 24, 2024
@dkhalanskyjb dkhalanskyjb added this to the 0.7.0 milestone Jul 24, 2024
@dkhalanskyjb dkhalanskyjb linked a pull request Jul 25, 2024 that will close this issue
Open
dkhalanskyjb added a commit that referenced this issue Jul 25, 2024
@dkhalanskyjb
Ensure different serial names for incompatible serializers
f678d42 
Fixes #416
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change This could break existing code bug Something isn't working
Projects
None yet
Milestone
0.7.0
Development

Successfully merging a pull request may close this issue.

Rework the serializers using the DateTimeFormat API Kotlin/kotlinx-datetime
1 participant
@dkhalanskyjb