Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S3 バケットの名称を変更 #258

Open
mt-osho-san opened this issue Dec 28, 2024 · 0 comments
Open

S3 バケットの名称を変更 #258

mt-osho-san opened this issue Dec 28, 2024 · 0 comments
Assignees
@mt-osho-san

Comments

@mt-osho-san
Copy link
Collaborator

original_image_bucket : 花瓶とか、花とかの元画像
flower_bucket : 花瓶、ラッピングの画像
bouquet_bucket : 花束の画像
@mt-osho-san mt-osho-san self-assigned this Dec 28, 2024
@mt-osho-san mt-osho-san mentioned this issue Dec 29, 2024
Merged
mt-osho-san added a commit that referenced this issue Jan 1, 2025
@mt-osho-san
feat: S3バケット名の変更と新規バケット追加 (#260)
7d87492 
### **User description**
## 概要

S3 バケットの名前を修正しました。

## 変更点

original_image_bucket : 花瓶、ラッピング、花の元画像
flower_bucket : ユーザーごとの花瓶、ラッピングの画像
bouquet_bucket : ユーザーごとの花束の画像

## 影響範囲

Bucket を利用している箇所の変数を変えたが、機能としての変更はないです。

## テスト

とくになし。

## 関連 Issue

- 関連 Issue: #258


___

### **PR Type**
Enhancement


___

### **Description**
- S3バケットの名称を`flowerImageBucket`から`originalImageBucket`に変更しました。
- 新たに`flowerBucket`を追加しました。
- これに伴い、関連する環境変数名も変更されています。



___



### **Changes walkthrough** 📝
<table><thead><tr><th></th><th align="left">Relevant
files</th></tr></thead><tbody><tr><td><strong>Configuration
changes</strong></td><td><details><summary>7 files</summary><table>
<tr>
  <td>
    <details>

<summary><strong>backend-stack.ts</strong><dd><code>S3バケット名の変更と新規バケット追加</code>&nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></summary>
<hr>

src/backend/lib/backend-stack.ts


<li><code>flowerImageBucket</code>を<code>originalImageBucket</code>に変更<br>
<li> <code>flowerBucket</code>を新たに追加<br>


</details>


  </td>
<td><a
href="https://github.com/Kota8102/diary-app/pull/260/files#diff-06e1c6bd40e02f92caf5b369458b80d4e45af5caa36d7fecd56e41898759a482">+3/-2</a>&nbsp;
&nbsp; &nbsp; </td>

</tr>

<tr>
  <td>
    <details>
<summary><strong>bouquet.ts</strong><dd><code>バケット名の変更</code>&nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></summary>
<hr>

src/backend/lib/constructs/bouquet.ts

- `flowerImageBucket`を`originalImageBucket`に変更



</details>


  </td>
<td><a
href="https://github.com/Kota8102/diary-app/pull/260/files#diff-a6fb5c43de5e3b52699104380fdaac619d49f7d3a33f8884a39d0600f98d0cd9">+3/-3</a>&nbsp;
&nbsp; &nbsp; </td>

</tr>

<tr>
  <td>
    <details>

<summary><strong>diary.ts</strong><dd><code>バケット名の変更と新規バケット追加</code>&nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
</dd></summary>
<hr>

src/backend/lib/constructs/diary.ts


<li><code>flowerImageBucket</code>を<code>originalImageBucket</code>に変更<br>
<li> <code>flowerBucket</code>を新たに追加<br>


</details>


  </td>
<td><a
href="https://github.com/Kota8102/diary-app/pull/260/files#diff-7116f23fe864dd19db3c0bdb379edee7244f27426cf611b874cd52ee511339b6">+6/-3</a>&nbsp;
&nbsp; &nbsp; </td>

</tr>

<tr>
  <td>
    <details>

<summary><strong>flower.ts</strong><dd><code>バケット名の変更と新規バケット追加</code>&nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
</dd></summary>
<hr>

src/backend/lib/constructs/flower.ts


<li><code>flowerImageBucket</code>を<code>originalImageBucket</code>に変更<br>
<li> <code>flowerBucket</code>を新たに追加<br>


</details>


  </td>
<td><a
href="https://github.com/Kota8102/diary-app/pull/260/files#diff-dceb79f3fee8c8c43e3194e7c9b72585a2c05c16b76cb7291e865239f63758a2">+19/-8</a>&nbsp;
&nbsp; </td>

</tr>

<tr>
  <td>
    <details>

<summary><strong>bouquet_create.py</strong><dd><code>環境変数名の変更</code>&nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></summary>
<hr>

src/backend/lambda/bouquet_create/bouquet_create.py

- 環境変数`FLOWER_BUCKET_NAME`を`ORIGINAL_IMAGE_BUCKET_NAME`に変更



</details>


  </td>
<td><a
href="https://github.com/Kota8102/diary-app/pull/260/files#diff-e201a05062a388488f791d8cfab469ef81b1197892abcc1a5bd37b9aedcaa2fc">+2/-2</a>&nbsp;
&nbsp; &nbsp; </td>

</tr>

<tr>
  <td>
    <details>

<summary><strong>diary_create.py</strong><dd><code>環境変数名の変更</code>&nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></summary>
<hr>

src/backend/lambda/diary_create/diary_create.py

- 環境変数`FLOWER_IMAGE_BUCKET_NAME`を`ORIGINAL_IMAGE_BUCKET_NAME`に変更



</details>


  </td>
<td><a
href="https://github.com/Kota8102/diary-app/pull/260/files#diff-91de867169029d0f2238953193ea58bb23800ae9d21705196d3b406b15dda6d5">+1/-1</a>&nbsp;
&nbsp; &nbsp; </td>

</tr>

<tr>
  <td>
    <details>
<summary><strong>flower_get.py</strong><dd><code>環境変数名の変更</code>&nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></summary>
<hr>

src/backend/lambda/flower_get/flower_get.py

- 環境変数`BUCKET_NAME`を`FLOWER_BUCKET_NAME`に変更



</details>


  </td>
<td><a
href="https://github.com/Kota8102/diary-app/pull/260/files#diff-20deb6a947c7ea9234f42c037e464d081a7cdc981a728a56a6b0be18a15d577a">+1/-1</a>&nbsp;
&nbsp; &nbsp; </td>

</tr>

</table></details></td></tr><tr><td><strong>Tests</strong></td><td><details><summary>2
files</summary><table>
<tr>
  <td>
    <details>

<summary><strong>test_diary_create.py</strong><dd><code>テスト用環境変数名の変更</code>&nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; </dd></summary>
<hr>

src/backend/test/pytest/test_diary_create.py

- 環境変数`FLOWER_IMAGE_BUCKET_NAME`を`ORIGINAL_IMAGE_BUCKET_NAME`に変更



</details>


  </td>
<td><a
href="https://github.com/Kota8102/diary-app/pull/260/files#diff-d25dbd46b57eddd480c9808aeb42c52476fd265952e5a0eeba4af48fce960886">+2/-2</a>&nbsp;
&nbsp; &nbsp; </td>

</tr>

<tr>
  <td>
    <details>

<summary><strong>test_flower_get.py</strong><dd><code>テスト用環境変数名の変更</code>&nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; </dd></summary>
<hr>

src/backend/test/pytest/test_flower_get.py

- 環境変数`BUCKET_NAME`を`FLOWER_BUCKET_NAME`に変更



</details>


  </td>
<td><a
href="https://github.com/Kota8102/diary-app/pull/260/files#diff-022477878acf4af0ce7a3747995d8a4e7de3cfdf7d083b9cbaba038278e7a2f3">+1/-1</a>&nbsp;
&nbsp; &nbsp; </td>

</tr>
</table></details></td></tr></tr></tbody></table>

___

> 💡 **PR-Agent usage**: Comment `/help "your question"` on any pull
request to receive relevant information
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mt-osho-san mt-osho-san

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mt-osho-san