Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YAC - 46, Adding tests #27

Merged
merged 2 commits into from
Oct 24, 2023
Merged

YAC - 46, Adding tests #27

merged 2 commits into from
Oct 24, 2023

Conversation

mfl15
Copy link
Contributor

@mfl15 mfl15 commented Oct 16, 2023

No description provided.

@mfl15 mfl15 requested review from dkoslicki and chunyuma October 16, 2023 17:26
@mfl15 mfl15 changed the title Adding tests YAC - 46, Adding tests Oct 16, 2023
dkoslicki
dkoslicki requested changes Oct 16, 2023
View reviewed changes
tests/testdata/20_genomes_sketches.zip Outdated Show resolved Hide resolved
tests/testdata/sample.sig Outdated Show resolved Hide resolved
tests/unittests.py Outdated Show resolved Hide resolved
@mfl15 mfl15 marked this pull request as draft October 19, 2023 23:25
@mfl15 mfl15 requested a review from dkoslicki October 23, 2023 13:48
@mfl15 mfl15 marked this pull request as ready for review October 23, 2023 13:50
mfl15
mfl15 commented Oct 23, 2023
View reviewed changes
Copy link
Contributor Author

@mfl15 mfl15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dkoslicki dkoslicki merged commit 784ab89 into main Oct 24, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkoslicki dkoslicki dkoslicki approved these changes

@chunyuma chunyuma Awaiting requested review from chunyuma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mfl15 @dkoslicki