You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
scotty currently only supports JSON logs when it comes to formatting of the logs. However, there are other common formats out there scotty should support.
This issue should not only focus on including a new log format but further establish a clean concept and APIs such that further formats can be added by only adding a new "formatter/parser".
For the sake of this issue I would suggest to implement a parser/formatter for logfmt logs.
With this issue it would be great to solve the following:
remove the direct dependency within the store/formatter.go that only uses a JSON parser towards a generic solution.
implement the option to parse logfmt logs
Side notes:
When browsing and thereby formatting the logs we display indented JSON and it would be nice the use a different type of visualisation for the key/value pairs of the logfmt logs.
Maybe out of scope but something we need to think about is how knows which parse to use. It would be wasteful to try the parsers in sequence until one works. Much rather I would suggest - and that is out of scope - that beam is extended with a cmd flag to indicate which format is streamed. In case of ideas please open an issue in beam and cross-reference the issue in here.
Lastly, formats such as CLF or ELF should be treated as plain text and not be parsed nor formatted. As a matter of fact if the flag in beam is omitted, hence the format is unknown to scotty, scotty should treat the logs as plain text by default.
The text was updated successfully, but these errors were encountered:
scotty
currently only supports JSON logs when it comes to formatting of the logs. However, there are other common formats out there scotty should support.This issue should not only focus on including a new log format but further establish a clean concept and APIs such that further formats can be added by only adding a new "formatter/parser".
For the sake of this issue I would suggest to implement a parser/formatter for logfmt logs.
With this issue it would be great to solve the following:
store/formatter.go
that only uses a JSON parser towards a generic solution.Side notes:
When browsing and thereby formatting the logs we display indented JSON and it would be nice the use a different type of visualisation for the key/value pairs of the logfmt logs.
Maybe out of scope but something we need to think about is how knows which parse to use. It would be wasteful to try the parsers in sequence until one works. Much rather I would suggest - and that is out of scope - that
beam
is extended with a cmd flag to indicate which format is streamed. In case of ideas please open an issue in beam and cross-reference the issue in here.Lastly, formats such as CLF or ELF should be treated as plain text and not be parsed nor formatted. As a matter of fact if the flag in beam is omitted, hence the format is unknown to
scotty
,scotty
should treat the logs as plain text by default.The text was updated successfully, but these errors were encountered: