Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(.github): deprecate reuse of sca scan action in docker image scan #95

Merged
merged 1 commit into from
Mar 4, 2024
Merged

ci(.github): deprecate reuse of sca scan action in docker image scan #95

merged 1 commit into from
Mar 4, 2024

Conversation

saisatishkarra
Copy link
Collaborator

Summary

Copy over the scan steps for the docker image scan action without reusing from a local action within the same repo
Deprecate image inputs for SCA action.

Issue

  • Reusing a local shared action within a shared action that is invoked from some other caller workflow ina different repository has a limitation where the uses block doesn't allow for any variables interpolation.
  • Using symlink workaround works well on GH-hosted runners (with a hardcoded path in uses block) but doesn't run when the self-hosted runners / Windows OS when workspace paths are different.

@saisatishkarra
ci(.github): deprecate reuse of sca scan action in docker image scan
4e9f00b 
ci(.github): deprecate image inputs for sca action
@saisatishkarra saisatishkarra requested a review from a team as a code owner March 4, 2024 16:20
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024

Luacheck Report

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
4 tests ±0  4 ✅ ±0  0 💤 ±0  0 ❌ ±0 
8 runs  ±0  8 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 4e9f00b. ± Comparison against base commit b0ef627.

@saisatishkarra saisatishkarra merged commit 60c9b13 into main Mar 4, 2024
11 checks passed
@saisatishkarra saisatishkarra deleted the remove/reuse-sca-action branch March 4, 2024 16:27
lahabana added a commit to lahabana/kuma that referenced this pull request Mar 5, 2024
@lahabana
ci(github): use newer Kong/public-shared-actions
a79a864 
We need Kong/public-shared-actions#95 to
make this work on self-hosted runners

Signed-off-by: Charly Molter <[email protected]>
@lahabana lahabana mentioned this pull request Mar 5, 2024
Merged
5 tasks
lahabana added a commit to kumahq/kuma that referenced this pull request Mar 5, 2024
@lahabana
ci(github): use newer Kong/public-shared-actions (#9502)
a70cea5 
We need Kong/public-shared-actions#95 to
make this work on self-hosted runners

Signed-off-by: Charly Molter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsofronievk vsofronievk vsofronievk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saisatishkarra @vsofronievk