Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): improve logs for test.conformance #4527

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Conversation

programmer04
Copy link
Member

What this PR does / why we need it:

In logs for make test.conformance the below entry is presented as one line

INFO: deploying Kong RBACs to clusterINFO: deploying Kong knative RBACs to clusterINFO: deploying Kong gateway RBACs to clusterINFO: deploying Kong CRDs RBACs to clusterINFO: deploying Kong CRDs to clusterINFO: deploying Gateway CRDs to cluster    gateway_conformance_test.go:127: creating GatewayClass for gateway conformance tests

change in this PR breaks it in separate lines

INFO: deploying Kong RBACs to cluster
INFO: deploying Kong knative RBACs to cluster
INFO: deploying Kong gateway RBACs to cluster
INFO: deploying Kong CRDs RBACs to cluster
INFO: deploying Kong CRDs to cluster
INFO: deploying Gateway CRDs to cluster

Special notes for your reviewer:

Something to consider is to get rid of bare fmt.Printf in test helpers and use a preconfigured logger for this use-case. maybe something to investigate during loggers clean-up proposed in #1893.

@programmer04 programmer04 self-assigned this Aug 17, 2023
@programmer04 programmer04 requested a review from a team as a code owner August 17, 2023 08:24
@programmer04 programmer04 enabled auto-merge (squash) August 17, 2023 08:24
@programmer04 programmer04 merged commit e95fde0 into main Aug 17, 2023
@programmer04 programmer04 deleted the improve-logs branch August 17, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants