tests(clustering): enable incremental sync in hybrid mode #13914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
cherry-pick kong-ee
chobits
approved these changes
Nov 26, 2024
chronolaw
force-pushed
the
tests/revert_hybrid_inc_sync
branch
from
b0c0404
to
125257f
Compare
StarlightIbuki
approved these changes
Nov 28, 2024
| @@ -40,8 +40,9 @@ fixtures_cp.http_mock.my_server_block = [[ | |||
| } | |||
| ]] | |||
|
|
|||
| -- TODO: reenable the inc sync test | |||
| for _, inc_sync in ipairs { "off" } do | |||
| for _, v in ipairs({ {"off", "off"}, {"on", "off"}, {"on", "on"}, }) do | |||
There was a problem hiding this comment.
How about making it a part of helpers:
Suggested change
| for _, v in ipairs({ {"off", "off"}, {"on", "off"}, {"on", "on"}, }) do | |
| for _, v in helpers.all_rpc_combination() do |
There was a problem hiding this comment.
Nice idea, perhaps we could do it in another PR.
|
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13914-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13914-to-master-to-upstream
git checkout -b cherry-pick-13914-to-master-to-upstream
ancref=$(git merge-base ad5fdefe83fe5eb7ff924bd2d5f02a3bb96ed736 125257f7ba93e03205e6811bba7bb5687bbb2f4d)
git cherry-pick -x $ancref..125257f7ba93e03205e6811bba7bb5687bbb2f4d |
github-actions
bot
added
the
incomplete-cherry-pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
KAG-5918
KAG-5876
See: #13906 #13876
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix #[issue number]