Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate the parametersRef referenced by GatewayClass #982

Open
1 task
mlavacca opened this issue Jan 9, 2025 · 0 comments · May be fixed by #1021
Open
1 task

Validate the parametersRef referenced by GatewayClass #982

mlavacca opened this issue Jan 9, 2025 · 0 comments · May be fixed by #1021
Assignees
@mlavacca
Labels
area/gateway-api area/managed-gateways
Milestone
KGO v1.5.x

Comments

@mlavacca
Copy link
Member

mlavacca commented Jan 9, 2025

Problem Statement

The .spec.parametersRef field of the GatewayClass objects can be used to customize the Gateways behaviour. KGO accepts only GatewayConfiguration objects as parametersRef. We need to validate that in case a GatewayClass is managed by Kong, such a field must be unset or properly set.

Proposed Solution

Use the GatewayClassReasonInvalidParameters Accepted reason to reflect the status of the ParametersRef field.

Acceptance Criteria

  • In case the GatewayClass is managed by Kong and references an unsupported parametersRef, the GatewayClass is marked as not accepted with reason GatewayClassReasonInvalidParameters.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mlavacca mlavacca

Labels
area/gateway-api area/managed-gateways
Projects
None yet
Milestone
KGO v1.5.x
Development

Successfully merging a pull request may close this issue.

feat: set GWC accepted condition properly Kong/gateway-operator
1 participant
@mlavacca