Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define source of truth for ValidatingAdmissionPolicy objects and implement automation to keep it synced across dependents #1035

Open
pmalek opened this issue Jan 16, 2025 · 1 comment

Comments

@pmalek
Copy link
Member

pmalek commented Jan 16, 2025

Problem statement

#1007 and Kong/charts#1215 add first ValidatingAdmissionPolicy objects that are used to validate DataPlane objects. These were added as part of #949 due to limited cost allocation for CEL expressions on CRDs.

Ideally, we would not like to keep these in multiple places and this is what this issue aims to solve.

Discussed in https://kongstrong.slack.com/archives/C011RQPHDC7/p1736959907181309

Proposed solution

Move the added ValidatingAdmissionPolicy objects definitions to https://github.com/Kong/kubernetes-configuration under e.g. config/gateway-operator/validation and add an automation which will sync this with gateway-operator chart (in the location where these objects will land after Kong/charts#1215 merges).

@czeslavo
Copy link
Contributor

If we implement solution C from #770, we may leave the ValidatingAdmissionPolicy in KGO and treat it as a source of truth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants