Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cmd): enhance help message for kong2tf #1448

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Conversation

battlebyte
Copy link
Collaborator

enhance help message for generate-imports-for-control-plane-id flag

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 27.58%. Comparing base (3c24be7) to head (b13a38a).

Files with missing lines Patch % Lines
cmd/file_kong2tf.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1448      +/-   ##
==========================================
- Coverage   27.59%   27.58%   -0.01%     
==========================================
  Files          61       61              
  Lines        6283     6285       +2     
==========================================
  Hits         1734     1734              
- Misses       4421     4423       +2     
  Partials      128      128              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nowNick
Copy link
Contributor

nowNick commented Nov 22, 2024

Hey @battlebyte, I've rebased your PR to make the tests pass (the fix has just been merged to main branch)

@battlebyte
Copy link
Collaborator Author

Thanks @nowNick

@Prashansa-K Prashansa-K merged commit 9c2f736 into main Dec 12, 2024
19 checks passed
@Prashansa-K Prashansa-K deleted the feat/kong2tf-help branch December 12, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants