Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add konnect-control-plane-name flag and deprecate konnect-runtime-group-name #1000

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

GGabriele
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 1.88% and project coverage change: -0.10% ⚠️

Comparison is base (63b9742) 33.70% compared to head (9e1a36f) 33.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1000      +/-   ##
==========================================
- Coverage   33.70%   33.61%   -0.10%     
==========================================
  Files         101      101              
  Lines       12323    12357      +34     
==========================================
  Hits         4154     4154              
- Misses       7760     7794      +34     
  Partials      409      409              
Files Changed Coverage Δ
cmd/common.go 4.08% <0.00%> (-0.18%) ⬇️
cmd/common_konnect.go 7.33% <0.00%> (-0.15%) ⬇️
cmd/root.go 0.89% <0.00%> (-0.03%) ⬇️
dump/dump.go 1.44% <ø> (ø)
file/types.go 56.13% <ø> (ø)
file/writer.go 14.28% <0.00%> (ø)
konnect/runtime_group_service.go 0.00% <0.00%> (ø)
file/reader.go 61.84% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mikefero mikefero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great so far; are you waiting for the API changes? As is this looks perfect for the rename.

@@ -0,0 +1,12 @@
_format_version: "3.0"
_konnect:
runtime_group_name: default
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@GGabriele
Copy link
Collaborator Author

Looks great so far; are you waiting for the API changes? As is this looks perfect for the rename.

Correct. We can potentially address the API change later on too.

@GGabriele GGabriele marked this pull request as ready for review August 23, 2023 05:25
@GGabriele GGabriele requested a review from a team August 23, 2023 05:25
@mikefero
Copy link
Contributor

mikefero commented Sep 6, 2023

@Kong/team-docs We will need to re-generate new CLI documentation for this when the new release for decK becomes available tomorrow (2023/09/07).

@acgoldsmith
Copy link

@Kong/team-docs We will need to re-generate new CLI documentation for this when the new release for decK becomes available tomorrow (2023/09/07).

@mikefero, thanks - we will publish these updates with the rest of the rename content on 9/20.

@GGabriele GGabriele force-pushed the chore/runtime-group-rename branch from 4e656d2 to c8fdf12 Compare September 22, 2023 15:52
@GGabriele GGabriele requested a review from mikefero September 22, 2023 15:52
@GGabriele GGabriele merged commit 199b398 into main Sep 25, 2023
33 of 34 checks passed
@GGabriele GGabriele deleted the chore/runtime-group-rename branch September 25, 2023 16:32
AntoineJac pushed a commit that referenced this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants