-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add konnect-control-plane-name flag and deprecate konnect-runtime-group-name #1000
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1000 +/- ##
==========================================
- Coverage 33.70% 33.61% -0.10%
==========================================
Files 101 101
Lines 12323 12357 +34
==========================================
Hits 4154 4154
- Misses 7760 7794 +34
Partials 409 409
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great so far; are you waiting for the API changes? As is this looks perfect for the rename.
@@ -0,0 +1,12 @@ | |||
_format_version: "3.0" | |||
_konnect: | |||
runtime_group_name: default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Correct. We can potentially address the API change later on too. |
@Kong/team-docs We will need to re-generate new CLI documentation for this when the new release for decK becomes available tomorrow (2023/09/07). |
@mikefero, thanks - we will publish these updates with the rest of the rename content on 9/20. |
4e656d2
to
c8fdf12
Compare
No description provided.