Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload dialog #21

Open
Grizzly127 opened this issue Jul 11, 2023 · 6 comments
Open

Upload dialog #21

Grizzly127 opened this issue Jul 11, 2023 · 6 comments

Comments

@Grizzly127
Copy link
Contributor

Suggestion for a new Upload dialog

before:
Bildschirmfoto 2023-07-06 um 12 46 09

after:
Bildschirmfoto 2023-07-11 um 11 35 43

  • changed stepper header (with numbers)
  • I used uniformly fonts
  • drag and drop window
  • with help button for the information for folder and files (it is an information you usually only need once, like this it doesn't take too much space, but the information doesn't get lost)
  • disabled buttons, when nothing is uploaded
  • active buttons, when there was something uploaded

@HeyItsBATMAN @ZetOE @lozanaross

@HeyItsBATMAN
Copy link
Collaborator

Some thoughts:

  1. Maybe the list of files and their upload progress can also be made prettier

  2. We should think about focusing on folder upload. That way we can better force users to really upload everything that's needed for the model, which is especially helpful for everyone uploading OBJs with MTLs and texture files, because they just have to select the folder containing all the files.

  3. If we lock in on folders, as explained in thought 2, maybe we can entirely deprecate the single file selection. This was done when browser support for directory upload was bad, but this seems to be supported widely now: https://caniuse.com/?search=webkitdirectory


changed stepper header (with numbers)

On the live Kompakkt version none of the wizards/steppers use the numbered layout, so if we change it here, we should change it everywhere, right?
image
image
image

@lozanaross
Copy link

lozanaross commented Jul 20, 2023

Thanks @Grizzly127 & @HeyItsBATMAN for these neat suggestions.

From my perspective simplifying the wizards would be great. So I suggest:

  • Consistently adding numbers to the steppers
  • Consistently keeping titles of the wizards (@Grizzly127, I guess we need the titles for the cases that are not objects, like groups and collections).
  • Opting indeed to push people for using mostly folders. So we can get rid of the split between files / folders. The title "Upload a file or folders" can stay and it just needs to move directly above the dotted "drag and drop area". The text inside that area could say "Drag and drop files here or" "Choose a folder" (the latter being a button).
  • "Reset upload" button can be orange, but only in Semantic Kompakkt. It should be just outlined or grey in Kompakkt. The orange is the signature TIB color that distinguishes Semantic Kompakkt from Kompakkt.

@Grizzly127
Copy link
Contributor Author

Here is a new draft for the upload process. The "Reset upload" button is still orange for semantic Kompakkt. For kompakkt we can choose the pink button. A grey button would be a disabled button.

Bildschirmfoto 2023-07-26 um 11 31 28 0-305db1541b78">

What do you mean by "wizards" @lozanaross ?
What do you think about the design for the files and their upload process @HeyItsBATMAN ?

@lozanaross
Copy link

@Grizzly127 Wizards are all the stepper processes that happen inside separate dialogs (you know I'm old because this is a term from the 90s lol) - so editing an object, a group or a collection are different wizards and we should keep the "Edit... " title at the top of the dialog because that indicates what kind of wizard we're stepping through.

Minor point, but the whole reset button being orange somehow really draws my eyes there and actually reset is supposed to be a secondary step, so i think keeping it outlined with orange outline and orange text might be preferable, so it is clearly a secondary and not a primary button. Agree that grey is less appropriate in this case.

@lozanaross
Copy link

@Grizzly127 - can you add here the latest version with the new secondary button, then I'd say this is in a good shape to pass on to development.
@HeyItsBATMAN - I think this can be one of the priority issues for UI fixes.

@Grizzly127
Copy link
Contributor Author

this is the latest version with the new secondary button:
Bildschirmfoto 2023-08-17 um 11 51 31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants