You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
every name starts with an upper case letter (good)
format of ERC-20 type tokens xxx-20 is good as it is
acronyms are all uppercase like UTXO, SLP, ZHTLC (good)
single word full names like Matic, Ubiq, Moonriver are also good
multi word names: 'Ethereum Classic', 'RSK Smart Bitcoin', 'Smart Chain', are two words, but 'HecoChain', is one word in Pascal case. this is inconsistent. if there is existing code that depends on the current name 'HecoChain' (I assume there definitely is), we should make it an exception, and all future multi-word names should be two words
or consider 'Ethereum Classic', 'RSK Smart Bitcoin', 'Smart Chain' as exceptions and make all future multiword names Pascal case. just have to pick one style and stick to it
'TENDERMINT' should be 'Tendermint'
'TENDERMINTTOKEN' should be 'TendermintToken' or 'Tendermint Token' based on the decision for multiword names from the 5th point
I'm making a webpage that displays all these names in a single spot, so found this inconsistency.
it is also ok to decide that changing any of the existing names will cause too much unnecessary work in the API/GUI codebases. then I will write some exceptions for the webpage I'm creating and normalize the naming scheme just over there
if there is existing code that depends on the current name 'HecoChain' (I assume there definitely is), we should make it an exception, and all future multi-word names should be two words
GUIs may need an update - I'm sure Desktop will, though its not a large update. Will schedule some testing this week in CLI to see how API responds to modification of these names.
all the asset types in the current coins file:
observations + my opinions:
xxx-20
is good as it isor consider 'Ethereum Classic', 'RSK Smart Bitcoin', 'Smart Chain' as exceptions and make all future multiword names Pascal case. just have to pick one style and stick to it
I'm making a webpage that displays all these names in a single spot, so found this inconsistency.
it is also ok to decide that changing any of the existing names will cause too much unnecessary work in the API/GUI codebases. then I will write some exceptions for the webpage I'm creating and normalize the naming scheme just over there
cc: @smk762 @cipig @tonymorony
The text was updated successfully, but these errors were encountered: