Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Movie Set Collections don't create subdirectory for each collection #1809

Open
2 of 5 tasks
mihawk90 opened this issue Oct 24, 2024 · 1 comment
Open
2 of 5 tasks
Labels
component: movies gap Between bug and feature request

Comments

@mihawk90
Copy link

Describe the bug
Movie Set Collections don't create subdirectories for each collection when the "Separate artwork directory" option is used. This means that inevitably multiple collections are using the same artwork, and changing the artwork for a second collection also changes it for the first because it overwrites the file.

To Reproduce
Steps to reproduce the behavior:

  1. Import some movies with different Sets/Collections
  2. Open the Movie Sets list
  3. Select a Movie Set and change the artwork, then save
  4. Select a second Movie Set and notice the artwork from the first set showing there
  5. Change the artwork on the second set, then save
  6. Go back to the first set and notice the artwork changed

Expected behavior
Each collection should create its own subdirectory for their respective artwork.

Ideally the naming convention for this should be able to be changed by the user, either through regular settings or the advancedsettings.xml (Jellyfin for example appends [boxset] to collection names, e.g. Jumanji Collection [boxset]).

Screenshots
image

image
image

 pwd
/mnt/tank/media/collections
 ls -1
backdrop.jpg
'Fantastic Four Collection [boxset]'
'Jumanji Collection [boxset]'
'Madagascar Collection [boxset]'
'The Bourne Collection [boxset]'
'The Fast and the Furious Collection [boxset]'
'The Lord of the Rings Collection [boxset]'
'The Matrix Collection [boxset]'
'X-Men Collection [boxset]'

Note these directories were created by Jellyfin, so they are unrelated to ME (and also not being read).

MediaElch Version:

  • 2.12.1-dev (nightly)
  • 2.12.0 (stable)

Operating System:

  • Windows
  • macOS
  • Linux (distribution: Fedora 40 KDE)
@bugwelle bugwelle added gap Between bug and feature request component: movies labels Nov 4, 2024
@bugwelle
Copy link
Collaborator

bugwelle commented Nov 4, 2024

Thanks for your report! Sorry for the delay.

The movie-set feature needs to be reworked. It was supported only poorly when I started and I never got to improve it either. :-/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: movies gap Between bug and feature request
Projects
None yet
Development

No branches or pull requests

2 participants