error when requesting additional fields

[tacman]

$client->all(['fields' => ['abandoned','repository','type']);

Generates an error because source isn't set in $version:

I'll submit a PR

[tacman]

Actually, my PR isn't sufficient.

The problem is that the return value when passing 'fields' to list.json is an array of those fields.

    public function createPackageResults(array $package): Package
    {
        dd($package);

returns

[robbieaverill]

Hi @tacman, would you be interested in submitting another PR to fix this?

[tacman]

Can you point me in the right direction? For the project I was working on, I simply filtered them after retrieving.

[robbieaverill]

It seems like the error is caused by the code expecting the 'source' key to exist. In your example you're filtering fields and 'source' isn't one of those included. Perhaps a change like this might be sufficient to fix the issue:

- if ($version['source']) {
+ if (!empty($version['source'])) {

[tacman]

That's what I did in #102, but it wasn't enough.

[tacman]

So the key issue here is that depending on the parameters to list.json, it returns either a list of strings (package names), or if "fields" is present, a list of objects keyed by package names.

So we need some sort of test to see what the result is. It's kinda ugly. I guess we can get the result back and check for is_array or array_is_list.

Even better would be a real API, like API Platform. composer/packagist#1491