Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object management improvements #9

Open
wants to merge 48 commits into
base: master
Choose a base branch
from
Open

Conversation

CodingRays
Copy link
Member

@CodingRays CodingRays commented Feb 1, 2022

The object management upgrade is now basically feature complete.
The major changes are:

  • Added surface and swapchain support
  • Made a object set trait allowing custom object set implementations. This is already used for the swapchain.
  • Remove object manager as it didnt really serve any purpose anymore. The allocator was moved as a publicly accessible feature to the DeviceContext.

There is still a lot of documentation work left and tests are missing for the swapchain object set since we cant expect a surface in a CI run. Not sure how to handle that issue.

@hYdos
Copy link
Member

hYdos commented Feb 1, 2022

I'm a bit confused. You say that object manager has been removed but wasnt that the planned way to handle allocating objects?

@CodingRays
Copy link
Member Author

The object manager used to handle that. But with the object set upgrade pretty much all of that code was moved into the specific object sets. The only thing left in the manager was the allocator. But realistically there is no reason why the allocator should be separate from the device so i moved it into the DeviceContext struct. Every device now has a publicly accessible allocator. As a result the object manager struct had no purpose anymore.

@CodingRays CodingRays marked this pull request as ready for review February 3, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants