From 5a4392f01d3aa54492e581a6de1aefd8c4114e38 Mon Sep 17 00:00:00 2001 From: Animesh Kumar Date: Wed, 1 Nov 2023 18:47:07 +0530 Subject: [PATCH 1/3] fix: update old broken link to new one (#835) --- apps/studio/src/examples/tutorials/invalid.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/studio/src/examples/tutorials/invalid.yml b/apps/studio/src/examples/tutorials/invalid.yml index 132005624..eb950da03 100644 --- a/apps/studio/src/examples/tutorials/invalid.yml +++ b/apps/studio/src/examples/tutorials/invalid.yml @@ -1,4 +1,4 @@ -# This invalid file exists solely for educational purposes, and if you come across it, here is the tutorial: https://www.asyncapi.com/docs/tutorials/validate-documents +# This invalid file exists solely for educational purposes, and if you come across it, here is the tutorial: https://www.asyncapi.com/docs/tutorials/studio-document-validation asyncapi: '1.0.0' info: From 9fb615e2d91bc0bd748247db4d5b305020b3154c Mon Sep 17 00:00:00 2001 From: samz Date: Thu, 2 Nov 2023 11:47:43 +0100 Subject: [PATCH 2/3] chore: Add Amzani as a code owner (#827) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Fran Méndez --- CODEOWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CODEOWNERS b/CODEOWNERS index ea9c5da74..0f4227904 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -6,4 +6,4 @@ # The default owners are automatically added as reviewers when you open a pull request unless different owners are specified in the file. -* @fmvilas @boyney123 @mcturco @magicmatatjahu @KhudaDad414 @asyncapi-bot-eve \ No newline at end of file +* @fmvilas @boyney123 @mcturco @magicmatatjahu @KhudaDad414 @Amzani @asyncapi-bot-eve \ No newline at end of file From a81e35bc3e2890e9b4b0c8dcb279b288391d3c4f Mon Sep 17 00:00:00 2001 From: Khuda Dad Nomani <32505158+KhudaDad414@users.noreply.github.com> Date: Thu, 2 Nov 2023 15:37:22 +0000 Subject: [PATCH 3/3] [ADR-0005] support component styling with tailwind css in design system (#823) Co-authored-by: samz --- doc/adr/0005-use-tailwind-in-design-system.md | 24 +++++++++++++++++++ 1 file changed, 24 insertions(+) create mode 100644 doc/adr/0005-use-tailwind-in-design-system.md diff --git a/doc/adr/0005-use-tailwind-in-design-system.md b/doc/adr/0005-use-tailwind-in-design-system.md new file mode 100644 index 000000000..8f059955b --- /dev/null +++ b/doc/adr/0005-use-tailwind-in-design-system.md @@ -0,0 +1,24 @@ +# 5. Integrate Tailwind CSS into Design System for Styling + +Date: 2023-10-24 + +## Status + +Accepted + +## Context + +As of now, the design system doesn't provide a way to style components. +All of the styling has to be done in the `ui` package. why do we want to styling in design system? +Well, if we want to showcase how [Organisms](https://atomicdesign.bradfrost.com/chapter-2/#organisms) like Forms behave we need some basic styling support in design system as well. +The studio is already planning to use Tailwind CSS for its UI, making it a logical choice to consider Tailwind for the design system as well. + +## Decision + +We propose to integrate Tailwind CSS into our design system. This will allow us to use the tailwind utility classes in our design system as well, such as Forms. + +## Consequences + +- Tailwind utility classes will be usable in design system. +- Another tool (`concurently`) have to be used to run storybook and tailwind css side by side. +- design system will be more complex and harder to understand for newcomers.