Test aniso filter #3159
Open
Test aniso filter #3159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdashg
force-pushed
the
test-aniso-filter
branch
from
c78e7df
to
dcf8adb
Compare
|
Is it consistent across different GPUs? KhronosGroup/Vulkan-Docs#1361 could be related. |
|
Oof, sounds like these might be "Harsh Realities". |
kenrussell
requested changes
Oct 7, 2020
There was a problem hiding this comment.
texture-min-mag-filter.html fails on macOS in both Firefox Nightly 83.0a1 and Chrome Canary 87.0.4280.0, running on the Intel GPU. Results from Firefox follow. I think this test is a bit too stringent.
PASS WebGL context exists min: NEAREST mag: NEAREST aniso: 1 res: 255,0,0,255 PASS Result was 255,0,0,255 aniso: 2 res: 255,0,0,255 PASS Result was 255,0,0,255 mag: LINEAR aniso: 1 res: 255,0,0,255 PASS Result was 255,0,0,255 aniso: 2 res: 255,0,0,255 PASS Result was 255,0,0,255 min: LINEAR mag: NEAREST aniso: 1 res: 255,0,0,255 FAIL Result was 255,0,0,255 aniso: 2 res: 255,0,0,255 FAIL Result was 255,0,0,255 mag: LINEAR aniso: 1 res: 208,47,0,255 PASS Result was 208,47,0,255 aniso: 2 res: 209,46,0,255 PASS Result was 209,46,0,255 min: NEAREST_MIPMAP_NEAREST mag: NEAREST aniso: 1 res: 255,0,0,255 PASS Result was 255,0,0,255 aniso: 2 res: 209,46,0,255 FAIL Result was 209,46,0,255 mag: LINEAR aniso: 1 res: 255,0,0,255 PASS Result was 255,0,0,255 aniso: 2 res: 209,46,0,255 FAIL Result was 209,46,0,255 min: LINEAR_MIPMAP_NEAREST mag: NEAREST aniso: 1 res: 208,47,0,255 PASS Result was 208,47,0,255 aniso: 2 res: 209,46,0,255 PASS Result was 209,46,0,255 mag: LINEAR aniso: 1 res: 208,47,0,255 PASS Result was 208,47,0,255 aniso: 2 res: 209,46,0,255 PASS Result was 209,46,0,255 min: NEAREST_MIPMAP_LINEAR mag: NEAREST aniso: 1 res: 167,0,88,255 PASS Result was 167,0,88,255 aniso: 2 res: 146,32,77,255 FAIL Result was 146,32,77,255 mag: LINEAR aniso: 1 res: 167,0,88,255 PASS Result was 167,0,88,255 aniso: 2 res: 146,32,77,255 FAIL Result was 146,32,77,255 min: LINEAR_MIPMAP_LINEAR mag: NEAREST aniso: 1 res: 137,31,88,255 PASS Result was 137,31,88,255 aniso: 2 res: 146,32,77,255 PASS Result was 146,32,77,255 mag: LINEAR aniso: 1 res: 137,31,88,255 PASS Result was 137,31,88,255 aniso: 2 res: 146,32,77,255 PASS Result was 146,32,77,255
|
BTW - the commit's message refers to #3143 but the pull request doesn't. When this is ready for re-review could you please update this pull request's comment? Thanks. |
kenrussell
requested changes
Oct 8, 2020
There was a problem hiding this comment.
Thanks for the updates. Still fails on Intel GPUs on macOS:
PASS WebGL context exists
min: NEAREST
mag: NEAREST
aniso: 1
PASS Result was 255,0,0,255
aniso: 2
PASS Result was 255,0,0,255
mag: LINEAR
aniso: 1
PASS Result was 255,0,0,255
aniso: 2
PASS Result was 255,0,0,255
min: LINEAR
mag: NEAREST
aniso: 1
FAIL Result was 255,0,0,255
aniso: 2
FAIL Result was 255,0,0,255
mag: LINEAR
aniso: 1
PASS Result was 174,81,0,255
aniso: 2
PASS Result was 174,81,0,255
min: NEAREST_MIPMAP_NEAREST
mag: NEAREST
aniso: 1
PASS Result was 255,0,0,255
aniso: 2
FAIL Result was 174,81,0,255
mag: LINEAR
aniso: 1
PASS Result was 255,0,0,255
aniso: 2
FAIL Result was 174,81,0,255
min: LINEAR_MIPMAP_NEAREST
mag: NEAREST
aniso: 1
PASS Result was 174,81,0,255
aniso: 2
PASS Result was 174,81,0,255
mag: LINEAR
aniso: 1
PASS Result was 174,81,0,255
aniso: 2
PASS Result was 174,81,0,255
min: NEAREST_MIPMAP_LINEAR
mag: NEAREST
aniso: 1
PASS Result was 179,0,76,255
aniso: 2
FAIL Result was 122,57,76,255
mag: LINEAR
aniso: 1
PASS Result was 179,0,76,255
aniso: 2
FAIL Result was 122,57,76,255
min: LINEAR_MIPMAP_LINEAR
mag: NEAREST
aniso: 1
PASS Result was 122,57,76,255
aniso: 2
PASS Result was 122,57,76,255
mag: LINEAR
aniso: 1
PASS Result was 122,57,76,255
aniso: 2
PASS Result was 122,57,76,255
PASS getError was expected value: NO_ERROR : End of run
PASS successfullyParsed is true
TEST COMPLETE
|
Hey thanks for testing, but I'm still experimenting with it. I'll ask for
review when I think it's ready.
I suspect it's possible to pick some subset of these subtests to
standardize, but this is apparently novel research :p
…On Wed, Oct 7, 2020, 5:29 PM Ken Russell ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Thanks for the updates. Still fails on Intel GPUs on macOS:
PASS WebGL context exists
min: NEAREST
mag: NEAREST
aniso: 1
PASS Result was 255,0,0,255
aniso: 2
PASS Result was 255,0,0,255
mag: LINEAR
aniso: 1
PASS Result was 255,0,0,255
aniso: 2
PASS Result was 255,0,0,255
min: LINEAR
mag: NEAREST
aniso: 1
FAIL Result was 255,0,0,255
aniso: 2
FAIL Result was 255,0,0,255
mag: LINEAR
aniso: 1
PASS Result was 174,81,0,255
aniso: 2
PASS Result was 174,81,0,255
min: NEAREST_MIPMAP_NEAREST
mag: NEAREST
aniso: 1
PASS Result was 255,0,0,255
aniso: 2
FAIL Result was 174,81,0,255
mag: LINEAR
aniso: 1
PASS Result was 255,0,0,255
aniso: 2
FAIL Result was 174,81,0,255
min: LINEAR_MIPMAP_NEAREST
mag: NEAREST
aniso: 1
PASS Result was 174,81,0,255
aniso: 2
PASS Result was 174,81,0,255
mag: LINEAR
aniso: 1
PASS Result was 174,81,0,255
aniso: 2
PASS Result was 174,81,0,255
min: NEAREST_MIPMAP_LINEAR
mag: NEAREST
aniso: 1
PASS Result was 179,0,76,255
aniso: 2
FAIL Result was 122,57,76,255
mag: LINEAR
aniso: 1
PASS Result was 179,0,76,255
aniso: 2
FAIL Result was 122,57,76,255
min: LINEAR_MIPMAP_LINEAR
mag: NEAREST
aniso: 1
PASS Result was 122,57,76,255
aniso: 2
PASS Result was 122,57,76,255
mag: LINEAR
aniso: 1
PASS Result was 122,57,76,255
aniso: 2
PASS Result was 122,57,76,255
PASS getError was expected value: NO_ERROR : End of run
PASS successfullyParsed is true
TEST COMPLETE
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3159 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALHJDPVRKZTBVY5AXJY47LSJUBWPANCNFSM4SFKDGJQ>
.
|
|
Got it, wasn't sure whether there was an implicit review request. Thanks for advancing the state of the art in texture filtering testing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This runs clean on Firefox+Win+OpenGL, but not on ANGLE.
We should talk about how to resolve ANGLE's issues somehow.