Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup code before continuing antecedent removal for coclustering IV #461

Open
marcboulle opened this issue Nov 20, 2024 · 0 comments
Open
Assignees
Labels
Priority/1 To do after P0 v11 Issue for Khiops 11

Comments

@marcboulle
Copy link
Collaborator

Description

L'objectif de cette issue est essentiellement de régler le probleme des ensure sur les cout et de nettoyer le code, avant d'attaquer la suite des évolution algorithmiques.

To do

  • résolution des problèmes potentiel des ensure sur les coût
  • nettoyage des balises // CH IV..., // CH ...

Refactoring dans KWDataGridManager: unifier si possible le pattern des méthodes

  • cf. autres méthodes (ExportTerminalDataGrid, ExportNullDataGrid) qui utilisent implicitement le GetSourceDataGrid() du DataGridManager?
    void ExportDataGridWithMergedInnerAttributes(const KWDGInnerAttributes* mergedInnerAttributes, KWDataGrid* targetDataGrid);
    -Plus renommer la méthode, et avoir un paramètre de type KWDGInnerAttributes, comme les méthodes similaires?

void ExportReferenceDataGridWithGivenInnerAttributes(const KWDataGrid* inputDataGrid, const KWDataGrid* tokenizedDataGrid, KWDataGrid* targetDataGrid);
->
void ExportDataGridWithReferenceInnerAttributes(const KWDGInnerAttributes* referenceInnerAttributes, KWDataGrid* targetDataGrid);

  • le inputDataGrid du DataGridManager doit être l'ancien tokenizedDataGrid
  • le referenceInnerAttributes provient de l'ancien inputDataGrid->GetInnerAttributes()
  • ...

Context

  • Khiops version V11
@marcboulle marcboulle added v11 Issue for Khiops 11 Priority/1 To do after P0 labels Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority/1 To do after P0 v11 Issue for Khiops 11
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants