Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utility for finding the best threshold? #733

Open
ir2718 opened this issue Nov 22, 2024 · 3 comments
Open

Utility for finding the best threshold? #733

ir2718 opened this issue Nov 22, 2024 · 3 comments

Comments

@ir2718
Copy link
Contributor

ir2718 commented Nov 22, 2024

Hi,

I would like to use an ONNX optimized version of a model trained using your library. However, for the use case of one-shot classification I need to determine a threshold for classification. Are there any utility functions which can calculate the optimal threshold based on a validation set, and a metric that I want to optimize for?

@KevinMusgrave
Copy link
Owner

No there isn't a utility function for that. I guess you mean optimal distance for some k-nn based classification?

@ir2718
Copy link
Contributor Author

ir2718 commented Nov 23, 2024

Yes, that's exactly what I mean. Ideally, it would take in a model, distance, splits to evaluate, and metric to optimize for. Would you be open to PRs for this? Ofcourse, if you think this would be a good addition to the library.

@KevinMusgrave
Copy link
Owner

A PR would be great, assuming there isn't already a library that does this. There are probably other people looking for something similar, so I think it would be a good addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants