Skip to content
This repository has been archived by the owner on Mar 29, 2019. It is now read-only.

Unable to edit redirect_uri & redirect_uri #45

Open
lucien144 opened this issue Nov 28, 2015 · 6 comments
Open

Unable to edit redirect_uri & redirect_uri #45

lucien144 opened this issue Nov 28, 2015 · 6 comments

Comments

@lucien144
Copy link

Hey,
Is there any reason why there's no possibility of changing redirect_uri & cancel_url params to something other than $this->currentUrl ?

May this be possible in any future update? (I'm keen to prepare a pull request with this)

Thanks.

@fprochazka
Copy link
Member

Since the returnUrl should point to the signal of the component it doesn't make sense to me to allow it.
But if you give me a good use-case. I'm not strictly against changing it.

@lucien144
Copy link
Author

Well,
if you want to use FB login within FB tab (~ app in Facebook Page), it might be handy to ended up on different url from where you can redirect user back to FB tab.

You can do this on the initial page of course, but it might lead to redirect loop within the FB tab.

@fprochazka
Copy link
Member

@lucien144 that's what the signal query param is for, no?

@lucien144
Copy link
Author

@fprochazka Yeah, seems like this should be enough what you need. Thanks for pushing me to the right direction!

@fprochazka
Copy link
Member

@lucien144 let me know afterwards if it worked for you :)

@lucien144
Copy link
Author

@fprochazka Sorry, I thought I get it but probably no :) I've thought you are talking about signal params, eg. if I do this <a n:href="fbLogin-open!, isFbTab => 1">Login with Facebook</a> then I don't know where to get the $isFbTab on the response. Can you show me what did you mean?

Thank you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants