Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/starknet_blockHashAndNumber #40

Open
antiyro opened this issue Sep 17, 2023 · 6 comments
Open

feat/starknet_blockHashAndNumber #40

antiyro opened this issue Sep 17, 2023 · 6 comments
Assignees
Labels
good first issue Good for newcomers RPC RPC implementation related issues stale

Comments

@antiyro
Copy link
Member

antiyro commented Sep 17, 2023

Issue: Implement starknet_blockHashAndNumber RPC Call

Description:
The starknet_blockHashAndNumber RPC call has been implemented but requires further testing and verification against the entire state. This RPC call retrieves the most recent accepted block hash and number.

Parameters:
None.

Expected Result:
The latest block hash and number.

Potential Errors:

  • NO_BLOCKS: No blocks were found.

Testing:
Initial testings can be found here. However, these should not be considered complete and improvements are welcome.

Resources:

Comments:
Please comment below for coordination.

@antiyro antiyro added this to Deoxys Sep 17, 2023
@antiyro antiyro converted this from a draft issue Sep 17, 2023
@antiyro antiyro added the RPC RPC implementation related issues label Sep 17, 2023
@github-actions
Copy link

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍
Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale label Oct 18, 2023
@Tbelleng
Copy link

Tbelleng commented Jan 5, 2024

Can i take this one ?

@antiyro antiyro moved this from 🆕 New to 🏗 In progress in Deoxys Jan 5, 2024
@github-actions github-actions bot removed the stale label Jan 6, 2024
@Tbelleng Tbelleng moved this from 🏗 In progress to 👀 In review in Deoxys Jan 7, 2024
@antiyro antiyro moved this from 👀 In review to 🏗 In progress in Deoxys Jan 9, 2024
@antiyro antiyro added the good first issue Good for newcomers label Jan 10, 2024
@antiyro
Copy link
Member Author

antiyro commented Jan 12, 2024

stuff may have changed since september 17 please only reffer to official JSON-RPC specs https://github.com/starkware-libs/starknet-specs/blob/master/api/starknet_api_openrpc.json

@antiyro
Copy link
Member Author

antiyro commented Jan 15, 2024

This one should be ready for review

@Tbelleng
Copy link

This one got the good behavior, waiting full sync to confirm but should work without any problems 🚀

@Tbelleng Tbelleng moved this from 🏗 In progress to 👀 In review in Deoxys Jan 15, 2024
Copy link

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍
Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale label Feb 15, 2024
@antiyro antiyro moved this from 👀 In review to ✅ Done in Deoxys Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers RPC RPC implementation related issues stale
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants