From 1f4ef26ce338c5a04a1f5ee37ea4d07c40ccecb2 Mon Sep 17 00:00:00 2001 From: Monica Wheeler Date: Wed, 15 May 2024 13:50:10 -0500 Subject: [PATCH 1/4] chore: update browserslist dependency --- package.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/package.json b/package.json index c89f50eaa5..8d68cc616d 100644 --- a/package.json +++ b/package.json @@ -71,5 +71,6 @@ "watch:assets": "cd packages/sage-assets && yarn build:watch", "watch:react": "cd packages/sage-react && yarn build:watch", "watch:system": "cd packages/sage-system && yarn build:watch" - } + }, + "dependencies": {} } From 20a91b98b37e637affaadaa1267e24549b19f154 Mon Sep 17 00:00:00 2001 From: Phillip Lovelace Date: Fri, 31 May 2024 09:35:10 -0700 Subject: [PATCH 2/4] fix: removes dasherize variable used for attributes --- .../app/views/sage_components/_sage_form_select.html.erb | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/docs/lib/sage_rails/app/views/sage_components/_sage_form_select.html.erb b/docs/lib/sage_rails/app/views/sage_components/_sage_form_select.html.erb index b8c5652a7e..ac2bb959de 100644 --- a/docs/lib/sage_rails/app/views/sage_components/_sage_form_select.html.erb +++ b/docs/lib/sage_rails/app/views/sage_components/_sage_form_select.html.erb @@ -1,8 +1,7 @@ <% # Temporary variables here until refactor for 'name' is complete; see https://kajabi.atlassian.net/browse/SAGE-214 label = component.label || component.name; - select_id = component.id.downcase.dasherize if component.id; - select_name = label.downcase.dasherize; + select_id = component.id.downcase if component.id; %>
<%= label %> + <% if component.message.present? %>
From 2ad9f3a0e0cc9ae7c7f8a4e04a5a7c821fa427b7 Mon Sep 17 00:00:00 2001 From: Phillip Lovelace Date: Fri, 31 May 2024 10:22:23 -0700 Subject: [PATCH 3/4] fix: remove update --- package.json | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/package.json b/package.json index 8d68cc616d..c89f50eaa5 100644 --- a/package.json +++ b/package.json @@ -71,6 +71,5 @@ "watch:assets": "cd packages/sage-assets && yarn build:watch", "watch:react": "cd packages/sage-react && yarn build:watch", "watch:system": "cd packages/sage-system && yarn build:watch" - }, - "dependencies": {} + } } From 0a250e1a362ca7b79e1b34f87dab4305a6a11d73 Mon Sep 17 00:00:00 2001 From: Phillip Lovelace Date: Mon, 3 Jun 2024 10:50:41 -0700 Subject: [PATCH 4/4] fix: adjust id conditional --- .../app/views/sage_components/_sage_form_select.html.erb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/lib/sage_rails/app/views/sage_components/_sage_form_select.html.erb b/docs/lib/sage_rails/app/views/sage_components/_sage_form_select.html.erb index ac2bb959de..4891cd8a8d 100644 --- a/docs/lib/sage_rails/app/views/sage_components/_sage_form_select.html.erb +++ b/docs/lib/sage_rails/app/views/sage_components/_sage_form_select.html.erb @@ -1,7 +1,7 @@ <% # Temporary variables here until refactor for 'name' is complete; see https://kajabi.atlassian.net/browse/SAGE-214 label = component.label || component.name; - select_id = component.id.downcase if component.id; + select_id = component.id ? component.id.downcase : label.downcase.dasherize; %>