From 4d579a879f1af22083b42b02b36338ad7eae3121 Mon Sep 17 00:00:00 2001 From: Quinton Jason Date: Fri, 31 May 2024 11:37:22 -0500 Subject: [PATCH] Next Version Relese (#1892) * fix(dropdown): add check for el (#1885) * chore: update browserslist dependency * chore: remove empty package.json dependencies block * chore: update node engines to support v20 (#1888) Co-authored-by: Julian Skinner * fix(breadcrumbs): rails resolve has_back_icon bug (#1891) * fix(breadcrumbs): rails resolve has back icon prop bug when value is false * chore(breadcrumbs): add comment for code clarity --------- Co-authored-by: Phillip Lovelace Co-authored-by: Monica Wheeler Co-authored-by: Julian Skinner Co-authored-by: Julian Skinner --- .../app/views/sage_components/_sage_breadcrumbs.html.erb | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/lib/sage_rails/app/views/sage_components/_sage_breadcrumbs.html.erb b/docs/lib/sage_rails/app/views/sage_components/_sage_breadcrumbs.html.erb index 5f0527117d..020756b274 100644 --- a/docs/lib/sage_rails/app/views/sage_components/_sage_breadcrumbs.html.erb +++ b/docs/lib/sage_rails/app/views/sage_components/_sage_breadcrumbs.html.erb @@ -1,5 +1,6 @@ <% -has_back_icon = component.has_back_icon.present? ? component.has_back_icon : component.items.length() == 1 +# The intent is to set this prop to false unless the has_back_icon prop is explicitly set +has_back_icon = component.has_back_icon.nil? ? component.items.length() == 1 : component.has_back_icon is_progressbar = component.is_progressbar.present? && component.is_progressbar %>