Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Frequency" used in place of "phase" in Seasonality tutorial #468

Open
dgmulf opened this issue Apr 12, 2024 · 0 comments
Open

"Frequency" used in place of "phase" in Seasonality tutorial #468

dgmulf opened this issue Apr 12, 2024 · 0 comments

Comments

@dgmulf
Copy link

dgmulf commented Apr 12, 2024

In the fourier_features() example algorithm on the Seasonality lesson of the Time Series course, the variable name freq is given to a parameter which takes units of days/cycle. This was confusing to me at first, because unless I'm mistaken, frequency typically refers to measurements given in inverse units (cycles/day), whereas period refers to time per cycle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant