Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tarerobee configs are out of date #2773

Open
zer0Kerbal opened this issue Feb 7, 2023 · 6 comments
Open

Tarerobee configs are out of date #2773

zer0Kerbal opened this issue Feb 7, 2023 · 6 comments

Comments

@zer0Kerbal
Copy link

User brought this to my attention:

Can’t use Aniline22 with RealFuels

concerning:
https://github.com/KSP-RO/RealismOverhaul/tree/master/GameData/RealismOverhaul/RO_SuggestedMods/Taerobee

real (pun intended) question is: who should control/publish the Taerobee compatibility patches; doesn't matter to me

in either case, am already working on updating the patches.

Query - currently the part manufacturer is set to manufacturer = #autoLOC_501627, which localizes to #autoLOC_501627 = Jebediah Kerman's Junkyard and Spacecraft Parts Co. Would you like me to change the manufacturer to Aerojet General and/or add and an agency named Aerojet General to Taerobee (rather a simple issue)?

zed'K

@Capkirk123
Copy link
Member

This issue is unrelated the the Taerobee configs, rather, all configs that use the old tank type system (most of them) don't get access too new resources added by RO. This should be resolved be resolving that issue.

@zer0Kerbal
Copy link
Author

the Taerobee configs are out of date, and use the wrong part names. Correcting at least the part names will fix the basic issue.

@Capkirk123
Copy link
Member

Ok. I would advise setting the manufacturer to #roMfrAerojet, as found here

@zer0Kerbal
Copy link
Author

Plan is that over the next week or so to pick through the patches, and comment out redundant patches, and update the part names - will upload them and PR them in for you to look at.

@siimav
Copy link
Contributor

siimav commented Feb 8, 2023

and comment out redundant patches

One does not comment out redundant patches; one removes redundant patches.

@zer0Kerbal
Copy link
Author

and comment out redundant patches

One does not comment out redundant patches; one removes redundant patches.

agree - I meant comment out the parts of a patch that are redundant; however upon further thought - will just eliminate those parts instead. :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants