fix: do not compute terms if we know the result to be 0 #817

rflechtner · 2024-11-28T16:30:13Z

This means we don't compute the overflowing quadratic terms if we do not need the result.

Checklist:

I have verified that the code works
- No panics! (checked arithmetic ops, no indexing array[3] use get(3), ...)
I have verified that the code is easy to understand
- If not, I have left a well-balanced amount of inline comments
I have left the code in a better state
I have documented the changes (where applicable)
- Either PR or Ticket to update the Docs
- Link the PR/Ticket here

rflechtner · 2024-11-28T16:31:51Z

pallets/pallet-bonded-coins/src/tests/transactions/mint_into.rs

@@ -747,6 +747,7 @@ fn mint_without_collateral() {
 		});
 }

+#[ignore]


this now does not easily overflow any more, so still needs to be fixed up

rflechtner · 2024-11-28T16:32:22Z

@Ad96el do you think we'd have to make changes to benchmarking for this?

fix: do not compute terms if we know the result to be 0

e6d513f

rflechtner commented Nov 28, 2024

View reviewed changes