From e4b449bd23eb6987c91911f93f6446f0bc1d5c61 Mon Sep 17 00:00:00 2001 From: Juzer Shakir Date: Thu, 28 Dec 2023 23:18:09 +0530 Subject: [PATCH 1/3] design cta-button larger --- app/views/pages/home.html.erb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/views/pages/home.html.erb b/app/views/pages/home.html.erb index ed64a7a3..50e97374 100644 --- a/app/views/pages/home.html.erb +++ b/app/views/pages/home.html.erb @@ -7,6 +7,6 @@
Thaali tracking, simplified

Manage your thaalis & transactions effortlessly with real-time statistics

- <%= link_to "Free demo", login_path, id: "home__body_cta", class: "btn rounded-pill border border-0 fs-5 px-4 py-2" %> + <%= link_to "Free demo", login_path, id: "home__body_cta", class: "btn rounded-pill border border-0 fs-4 px-5 py-2" %> From cc1bcf65548c7291033fefe785438b88f9a41d70 Mon Sep 17 00:00:00 2001 From: Juzer Shakir Date: Fri, 29 Dec 2023 00:16:14 +0530 Subject: [PATCH 2/3] Convert dimensions to `rem`, remove unnecessary media queries. --- app/assets/stylesheets/pages/_home.scss | 25 ++++++++++--------------- app/views/pages/home.html.erb | 2 +- 2 files changed, 11 insertions(+), 16 deletions(-) diff --git a/app/assets/stylesheets/pages/_home.scss b/app/assets/stylesheets/pages/_home.scss index 61cb315e..6c3129c4 100644 --- a/app/assets/stylesheets/pages/_home.scss +++ b/app/assets/stylesheets/pages/_home.scss @@ -10,6 +10,16 @@ background-position: center; padding: 2.5rem 8rem; + &__header-logo { + width: 14rem; + height: 5.5rem; + + @media (min-width: 380px) { + width: 20rem; + height: 8rem; + } + } + &__body { margin-top: 22rem; letter-spacing: -0.05rem; @@ -82,11 +92,6 @@ @include media-breakpoint-down(xl) { #home { padding: 2.5rem 6rem; - - &__header-logo { - width: 280px; - height: 120px; - } } } @@ -94,11 +99,6 @@ @include media-breakpoint-down(lg) { #home { padding: 2.2rem 5rem; - - &__header-logo { - width: 250px; - height: 100px; - } } } @@ -113,10 +113,5 @@ @include media-breakpoint-down(sm) { #home { padding: 1.5rem 2rem; - - &__header-logo { - width: 230px; - height: 90px; - } } } diff --git a/app/views/pages/home.html.erb b/app/views/pages/home.html.erb index 50e97374..5c12f77b 100644 --- a/app/views/pages/home.html.erb +++ b/app/views/pages/home.html.erb @@ -1,6 +1,6 @@
- <%= image_tag("fmb-logo-full.png", width: "320", height: "130", alt: "FMB logo", id: "home__header-logo") %> + <%= image_tag("fmb-logo-full.png", alt: "FMB logo", id: "home__header-logo") %>
From 2105d4c006c8620028fc960b9e7313e4eb80838f Mon Sep 17 00:00:00 2001 From: Juzer Shakir Date: Fri, 29 Dec 2023 00:19:24 +0530 Subject: [PATCH 3/3] replace header with fmb logo --- app/views/sessions/new.html.erb | 4 +++- spec/features/sessions/new_spec.rb | 4 ++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/app/views/sessions/new.html.erb b/app/views/sessions/new.html.erb index 421fe7c2..d2d78fcc 100644 --- a/app/views/sessions/new.html.erb +++ b/app/views/sessions/new.html.erb @@ -1,7 +1,9 @@ <% content_for :title, "Login" %> <%# * Heading %> -

Faiz al-Mawaid al-Burhaniyah

+
+ <%= image_tag("fmb-logo-full.png", alt: "FMB logo", id: "home__header-logo") %> +
<%# * Login Form %> <%= render "form" %> diff --git a/spec/features/sessions/new_spec.rb b/spec/features/sessions/new_spec.rb index d751c50e..6b19ac52 100644 --- a/spec/features/sessions/new_spec.rb +++ b/spec/features/sessions/new_spec.rb @@ -9,6 +9,10 @@ it { expect(page).to have_title "Login" } + it "logo" do + expect(page).to have_css("img[src*='fmb-logo-full']") + end + it "shows footer" do expect(page).to have_css("#footer") end